This repository was archived by the owner on Jan 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
Improve challenge visibility control: review and search #508
Open
TheOsch
wants to merge
12
commits into
topcoder-archive:dev
Choose a base branch
from
TheOsch:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(https://www.topcoder.com/challenge-details/30057891/?type=develop) Verification guide: docs/Verification_Guide-Improve Challenge Visibility Control.doc
The eligibility check routine is now in challengeHelper and can be added anywhere by a couple of simple lines of code.
@TheOsch can you try |
From the console: .../tc-api$ git pull https://github.com/appirio-tech/tc-api.git dev |
wired, but you did so many commits? |
@TheOsch anyway, I will review that |
By mistake. I forgot a correct sequence of commands to merge 3 branches (appirio-dev, my and local) and did a merge several times. In fact there's only one significant commit there. |
If this PR is still needed, it needs to be updated to fit with #510 . Should I do it now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
13 actions updated, none left