-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes restrictions in viewport names #271
base: master
Are you sure you want to change the base?
Conversation
The restriction is there because vimwiki links may contain It's definitely possible to write a regexp that handles this, but it's going to be more complex than the current one. Several options come to my mind:
The third option is definitely the easiest, but I have no idea if that would be acceptable to @tbabej. It's also the one that is most likely to break some users' usecases. Either way, now that the tests are working and fast, it would be a good idea to add a few tests covering the various scenarios. |
b549521
to
36652d1
Compare
0d013a3
to
79df411
Compare
I went with the simplest approach. |
I also fixed markdown links not being followed. This is ready to merge if you have no comments. |
67c6d0a
to
5637294
Compare
@tbabej Friendly reminder that this seems ready to merge. |
5637294
to
9015566
Compare
9015566
to
6e12137
Compare
In the regexp that handle viewports, there is the restriction on header names to not include the
]
or}
characters. I couldn't see why this restriction is in place as the|
is what actually matters.This PR removes the restriction. It means to address #256 .