Update from original fork #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted by Marc Madaule (thanks!), the mono AAC decode was not functioning properly. Adjust the output stuff loop to fix.
Bugfixes to AAC and Opus codec addition
* test/run on host to null device * compilation fix
* separate malloc structures * add desync() for user when randomly seeking in the input file fix corner cases leading to exceptions when seeking * additional test when trying to crash-shake everything with a rotary encoder seeking into the currently played file * use private instead of static * remove temporary debug code
PlatformIO requires these dependencies to be explicitly mentioned. Please check the version numbers of the libraries specified are correct. However, v1.0 for each allows for successful builds. Thanks!
When reusing the AudioGeneratorMP3 object to play multiple files with errors, the error count was never reset. Also, if 3 errors are encountered, it would stop running but never clean up the buffers.
Code courtesy of Martin Laclaustra. Uses the ULP coprocessor on the ESP32 to send samples to the onboard DACs, freeing the I2S port for other uses. Connect left output to pin 25, right to pin 26.
…ned into the fs namespace in esp32 libraries. (#335) Co-authored-by: Pierre-Loup Martin <[email protected]>
* Modified AudioFileSourceFS.h to add resolution operator on items defined into the fs namespace in esp32 libraries. * Added track, set, popularimeter, compilation tags. Changed framesize loop with 32bit counter to avoid endless loops for large frames (like APIC). Co-authored-by: Pierre-Loup Martin <[email protected]>
* Fix the order of mono samples (each pair was swapped) * Remove comment on version and date (currently tracked within ESP8266Audio repo) * Added some usage instructions to the header file * Delete sample in buffer after being rendered (ULP) to avoid sound looping in the buffer at the end of playback Co-authored-by: Martin-Laclaustra <[email protected]>
* esp8266: Allows I2S-NoDAC to use only I2S-out-data GPIO avoiding conflicts with repurposed GPIO, especially conflicting with SDFS. * +message * new upstream API update * check i2s_begin's return value
Thanks to @cjwhoishe, fixes #355 . When a large enough read size was requested it is possible that for some streams multiple ICY blocks could appear. The logic doesn't support that, so only read up to 1/2 the ICY block interval to ensure there is no way to see two ICY blocks in one readInternal call.
Thanks to @d-a-v for the debug!
* replace a disappeared shoutcast url by a working one from another example * increase a buffer size (found by valgrind) * make emulated example closer to the not emulated one use `./onHost diff` to show the diff -u * add `diff` option to onHost script * add a delay to local copy of AudioOutputNull * increase another buffer size * make AudioOutputNullSlow.h compatible with arduino api (not only emulation on host)
Ensure the ICY decoder fixes make their way out.
* StreamOnHost: actually play audio * (spaces) * fix comment * update message
* Add arduino-lint CI check * Fix linting warnings
…th the fixed-point CPU of the ESP8266 (#370)
ESP32: When calling destructor after stop, and then create a new object, then an error is shown "I2S: register I2S object to platform failed" because i2s_driver_uninstall had not been called. ESP8266 : i2s_end is not called when stopping, but i2sOn is false, resulting in new call i2s_rxtx_begin
Uses the RP2040 HW PWM generator to provide a stereo audio signal.
Corrected format to formant.
* Fix GCC12.3 new warnings for RP2040 * Remove OPUS encoder, not supported on embedded
Implement the renamed network client and other API changes when built under the 3.x branch of the Arduino ESP32 core. Disable building TSF on the ESP32, the Xtensa G++ backend bug is still there. Minimal changes to get I2S to build under new IDF. Deprecated but not removed, so warnings are expected but should not be fatal in use. Fixes #683
* Fix pedantic GCC14 warnings on calloc order * Ensure AAC read-in doesn't overflow internal structures when the file is corrupted/illegal.
Co-authored-by: RASMUSSEN Joern <[email protected]>
…266 (empirically tested) (#554) * Performance improvement - new tsf_note_on_fast returning playIndex and removing lowpass filter setup since it is not being processed in tsf_voice_render_fast anyway but is consuming a lot of cpu - new tsf_note_off_fast using playIndex to stop voices faster - Removing lowpass filter setup from tsf_voice_render_fast since it is not being processed - Math tweaks trying to avoid complex math operations (specially conversions) at voice render stage - Precalculating *F32P32 values to avoid doing them at voice render stage * Fixing data type * Initializing play indexes --------- Co-authored-by: Edgar <[email protected]>
dot_a_linkage seems to cause issues with CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.