Fix clippy 1.73 lints, update lint configuration #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way around Fixes clippy 1.73 lint. This different order makes sense, as it avoids an expect().
I must have been mistaken when originally introducing `clippy:all`, because these are, by definition, lints that are enabled without any configuration: https://doc.rust-lang.org/stable/clippy/usage.html#lint-configuration Add a lint that catches `todo!()` (but allows `panic!()`, `unreachable!()`, `unimplemented!()`) - you're encouraged to use it during development as a reminder for stuff to finish before a change can be merged.
strohel
added a commit
to tonarino/rusty-yunet
that referenced
this pull request
Sep 29, 2024
I must have been mistaken when originally introducing `clippy:all`, because these are, by definition, lints that are enabled without any configuration: https://doc.rust-lang.org/stable/clippy/usage.html#lint-configuration Add a lint that catches `todo!()` (but allows `panic!()`, `unreachable!()`, `unimplemented!()`) - you're encouraged to use it during development as a reminder for stuff to finish before a change can be merged. Sibling in `actor`: tonarino/actor#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timed::QueueItem: Implement partial_cmp() using cmp(), not the other way around
Fixes clippy 1.73 lint.
This different order makes sense, as it avoids an expect().
Clippy lints update:
allis implied, addtodoI must have been mistaken when originally introducing
clippy:all, because these are, by definition, lints that are enabled without any configuration: https://doc.rust-lang.org/stable/clippy/usage.html#lint-configurationAdd a lint that catches
todo!()(but allowspanic!(),unreachable!(),unimplemented!()) - you're encouraged to use it during development as a reminder for stuff to finish before a change can be merged.