Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category signedness check in manual-dns-manage.fif #901

Open
wants to merge 1 commit into
base: testnet
Choose a base branch
from
Open

Fix category signedness check in manual-dns-manage.fif #901

wants to merge 1 commit into from

Commits on Feb 12, 2024

  1. Fix category signedness check in manual-dns-manage.fif 

    Fix a check in manual DNS management Fift script, that verifies the category number as an signed `int256` instead of unsigned `uint256,` that this number is actually treated as later in the code (`256 u,`).

Importance of this fix is that the common `"wallet"H` category hash is `0xe8d44050873dba865aa7c170ab4cce64d90839a34dcfd6cf71d14e0205443b1b`, and therefore has a high bit set - therefore without this fix it is impossible to create subdomains in the `"wallet"H` category.
    @Skydev0h
    Skydev0h authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    02b703b View commit details
    Browse the repository at this point in the history