Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improve how local block styles are set #1485

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

tomusborne
Copy link
Owner

This PR makes it so our local blocks use the styles attribute as their styles store, instead of having a separate styles store we have to constantly sync with.

requires https://github.com/EDGE22-Studios/block-styles/pull/9
requires https://github.com/EDGE22-Studios/styles-builder/pull/17

@tomusborne tomusborne added the refactoring Refactoring, minor code changes label Nov 15, 2024
@tomusborne tomusborne added this to the 2.0.0 milestone Nov 15, 2024
Copy link
Collaborator

@iansvo iansvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a few tweaks made in the other PRs, this is working as expected in local testing.

@tomusborne tomusborne merged commit d2b45eb into release/2.0.0 Nov 15, 2024
9 checks passed
@tomusborne tomusborne deleted the refactor/local-style-setting branch November 15, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring, minor code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants