Make doctrine role a database-level setting #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for migrations while using Doctrine ORM. The initial migration is based on the current `main`. Normally, a `migrations:rollup` would be used to ensure that this migration is successful. However, in our case it is necessary to export ALL data (but not structure) from the database, drop everything in the database, and only then perform the migration. Data can be easily exported from PostgreSQL using: ```sh pg_dump -U gewisdb --column-inserts --data-only gewisdb pg_dump -U gewisdb --column-inserts --data-only gewisdb_report ``` This ensures that _all_ FKs are the same for newer migrations preventing headaches in the future. --- Convenience methods have been added for `make` to make using the migrations easier. However, in production everything must go directly through `./orm`.
Initially, I attempted to use the `wrapperClass` option to handle setting the database role. However, I encountered issues because DBAL checks for the exact `Connection` class type and not the interface, making it difficult to extend the `Connection` class as needed. I also considered overwriting the PgSQL-specific connection class (PDO variant) to set the role upon connection. Unfortunately, this was not an option because the class is declared as `final`, preventing me from extending it. The next potential solution was to use an `EventSubscriber` to set the role after the connection was established (using `postConnect`). However, this approach is already deprecated in our version of DBAL and completely removed in the next major release, rendering it unsuitable for us (maintainability). Ultimately, I implemented the `SET ROLE` functionality using DBAL's middleware. By wrapping the driver, and manually creating the `Connection` we can perform the `SET ROLE` query before the connection is used by the application. Runtime checks exist to ensure that the role (`DOCTRINE_ROLE`) is defined. However, validation of the actual value is done by PostgreSQL itself (it will complain if the role does not exist).
5 tasks
rinkp
force-pushed
the
pr/tomudding-doctrine-migrations
branch
from
dcc9d4f to
3430fa5
Compare
tomudding
force-pushed
the
chore/doctrine-migrations
branch
from
fe02177 to
f80419f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.