QuickfixsignsListBufferSigns: use sign_getplaced #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: does not set/have the "sign" attribute (easily), only used with AssertUniqueSigns, where it could be removed/replaced - maybe only for the new method / if missing then?! Fixes tomtom#83.
|
@tomtom any feedback? |
|
I currently have no recent version of vim available that already has the sign_*() functions, which is why I cannot test it etc. I also wonder if qfs is still necessary with the new sign api since it originated in an effort to work around the limitations of the old api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: does not set/have the "sign" attribute (easily), only used with
AssertUniqueSigns, where it could be removed/replaced - maybe only for
the new method / if missing then?!
Fixes #83.