Skip to content

added: my solutions in javascript to the caesar cipher challenge #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions challenges/easy/caesar-cipher/solutions/valentinadagata/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
const letters = 26;

function encode(str, shift) {
let new_shift = shift % letters

return str.split("").map(character => {
// if is a letter
if ((character >= "a" && character <= "z") || (character >= "A" && character <= "Z")) {

// if is uppercase
let ascii = 65

// if is lowercase
if (character >= "a" && character <= "z") {
ascii = 97
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this ascii variable come from?

}

let new_str = (letters + character.charCodeAt(0) - ascii + new_shift) % letters
let encrypt = String.fromCharCode(new_str + ascii)
return encrypt
}
// don't encrypt if it's not a letter
else return character;
}).join("");
}


function decode(str, shift) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you're repeating most of the encode function. Is there a way to avoid all those repetitions?

new_shift = -shift
return encode(str, new_shift)
}


/*
// encode test
console.log(encode('Hello, World!', 7)); // => 'Olssv, Dvysk!'
console.log(encode('I love pizza.', -7)); // => 'B ehox ibsst.'
console.log(encode('HytyQapgnr kyicq qclqc. Qmkcrgkcq.', 50)); // => 'HytyQapgnr kyicq qclqc. Qmkcrgkcq.'
console.log(encode('abc', 24)); // => 'yza'


// decode test
console.log(decode('CxvxaaxfMneb Axltb!', 9)); // => 'TomorrowDevs Rocks!'
console.log(decode('Gtdflw Defotz Nzop td rcple!!!', -15)); // => 'Visual Studio Code is great!!!'
console.log(decode('Vriwzduh Hqjlqhhulqj', 3)); // => 'Software Engineering'
console.log(decode("Buj'i mhyju jxu syfxuh.", 120)); // => "Let's write the cipher."
*/