Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates KDEpy to be Python 2 compatible #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updates KDEpy to be Python 2 compatible #30

wants to merge 1 commit into from

Conversation

theodoretliu
Copy link

The current version of the library only supports Python 3. Using some
future imports and removing some type annotations, this make the library
backwards compatible with Python 2.

Updates KDEpy to be Python 2 compatible
ae855b9 
The current version of the library only supports Python 3. Using some
future imports and removing some type annotations, we make the library
backwards compatible with Python 2.
@tommyod
Copy link
Owner

tommyod commented Aug 17, 2019

Thanks a lot @theodoretliu . I'm interested in backwards compatibility in general - but more so to earlier versions of 3 than to Python 2, considering that Python 2 end of life is in a few months. Will look over this 👍

May I ask if you needed to run in on Python 2 yourself, and if so why?

@tommyod tommyod self-requested a review August 17, 2019 04:48
@theodoretliu
Copy link
Author

I have a few projects that still require Python 2 and your package! But I'm also happy to look at previous Python 3 version compatibility too!

@theodoretliu
Copy link
Author

I used pyenv to also test on Python versions 3.5.7, 3.6.9, and 3.7.4, which all are not deprecated per https://devguide.python.org/.

When I tested with 3.8.0b3+, there were failures, but they were with the installation of numpy version 1.17.0. It seems like the developers of numpy are not focusing on 3.8 until it's an official release (per numpy/numpy#14260 (comment)).

Let me know if there's anything else you would like tested out!

@tommyod
Copy link
Owner

tommyod commented Aug 21, 2019 •
edited
Loading

Great. Thanks a lot!

Since Python 2 reaches EOL soon, I will not merge this branch. I'd like to leave it open however. If someone needs a Py2 version, they can use the work in this branch 👍

tommyod
tommyod approved these changes Aug 21, 2019
View reviewed changes
Copy link
Owner

@tommyod tommyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Leaving it open in case it's useful for others needing a py2 compatible version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyod tommyod tommyod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theodoretliu @tommyod