This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Feature/sitemapindex #4
Open
+148
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReadMe has been modified to explain the new feature. The start option has been added. It starts automatically the element urlset. When set to false, it disable the startElement and needs a manual declaration with the method startElement. This method has been added to the SitemapGenerator. The methods addEntry and addSitemap now returns the Class to have the posibility to chain the entries together. (See the example into the readme.) A test has been added to the feature. I am not familiar yet with the library used. As PHPunit and PHPspecs are not implemented, I did not add those tests.
The tests have been adjusted for Behat after testing the project. The branch passed the tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request add the feature for sitemapindex.
The ReadMe has been modified to explain the new feature.
The start option has been added. It starts automatically the element
urlset. When set to false, it disable the startElement and needs a
manual declaration with the method startElement.
This method has been added to the SitemapGenerator.
The methods addEntry and addSitemap now returns the Class to have the
posibility to chain the entries together. (See the example into the
readme.)
A test has been added to the feature. I am not really familiar yet with Behat.
As PHPunit and PHPspecs are not implemented, I did not add those tests.