Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to prop-types and update deps according to redux-orm #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ojab
Copy link

@ojab ojab commented Oct 3, 2017

No description provided.

@ojab ojab force-pushed the master branch 2 times, most recently from d6e4201 to 86e8e0a Compare October 3, 2017 12:53
@ojab ojab force-pushed the master branch 2 times, most recently from e620d16 to 66d25c2 Compare October 3, 2017 13:02
@nealoke
Copy link

nealoke commented Oct 3, 2017

👍 please merge 📦

@pronebird
Copy link

pronebird commented Oct 4, 2017

Is it absolutely necessary to introduce the whole bunch of dependencies and rewrite everything with jest in order to add prop-types?

Why not to add prop-types in one tiny PR that's easy to review and then go incremental with the rest of changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants