Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for why this might not exist and found #368, which is concerned with whether
Range<usize>
is really the right representation for the field type or if it should hold something else, like a customSpan
type defined by serde_spanned.The same concern might apply to a
new
constructor, and if so, an approach that doesn't preclude construction with a better type in the future might be preferred. For exampleSpanned::new(value).with_range(range)
.Without some API to construct a
Spanned
at a given range, I do not know of any way to deserialize an untagged enum containingSpanned
fields. Context: dtolnay/serde-untagged#5