Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for on() and addEventListener(). #1

Closed
wants to merge 1 commit into from

Conversation

tomfaltesek
Copy link
Owner

Removed the if/else that checked for the existence of the on() and addEventListener() methods.

This is the block that was removed:

if (page.Page.on || page.Page.addEventListener) {
    console.log("NativeScript-globalevents auto disabled; functionality appears to be already present!");
} else {
  // Extend the Page object with the new events...
  // This code was left unmodified.
}

This should fix NathanaelA#7.

@tomfaltesek
Copy link
Owner Author

This might be overly simplistic. I'm anxious about overriding the NS Page on() and addEventListener() methods. Although this currently works in my NS Angular project, I'm not sure it's a great long-term solution.

@tomfaltesek tomfaltesek closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"_First" events are not being added to Page object
1 participant