Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed zoom detection for webkit(desktop) and Issue #41 #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed zoom detection for webkit(desktop) and Issue #41 #46

wants to merge 4 commits into from

Conversation

bitjoo
Copy link

@bitjoo bitjoo commented Aug 30, 2013

I have tested my webkit patch in the latest chromium 28. And on Windows Chrome 27.
Worked with devtools on the right side, activated sidbar and in iframes as well.

I have also fixed the uncaught type exception bug (#41).

@tombigel
Copy link
Owner

tombigel commented Sep 8, 2013

@BitWire cool, thanks!
I'll play with it a bit and merge and change the documentation accordingly this week.

@timbarlotta
Copy link

Manually applied the patch and ran some basic tests (chrome 30 on mac) and seems to work great. Did you find issues or any thoughts on officially merging?

@bitjoo
Copy link
Author

bitjoo commented Nov 21, 2013

Because document.width was deprecated and is now undefined in Chrome 30, I made some changes to my code and using the opera detection for webkit now.
Tested in Chromium Version 30.0.1599.114 Built on Ubuntu 13.04, running on LinuxMint 15 (30.0.1599.114-0ubuntu0.13.04.2)

Please have a look.

@nhodges
Copy link

nhodges commented Jan 18, 2014

@BitWire Doesn't look like your latest pull request is working anymore. Might it be possible to use window.devicePixelRatio now, which has been implemented in Chrome since v31?

Cheers!

@bitjoo
Copy link
Author

bitjoo commented Jan 23, 2014

@nhodges Thank you for your hint. Yes, you can use window.devicePixelRatio. Since Chrome 31 it takes full-page zoom, but not pinch zoom, into account. To get sure, I added a solution with a SVG (iframes not supported). I had to change the browser detection as well, because in Chrome 31 they removed support for the prefixed -webkit-marquee.

If you want to support only the latest browsers for full-page zoom, you can get rid of this plugin and just use window.devicePixelRatio (since Firefox 18, Chrome 31 and IE11, it has the same behaviour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants