pixelformats: Use pixel groups instead of verticalsubsampling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point we have horizontalsubsampling and verticalsubsampling. Then we had bytespergroup and verticalsubsampling, i.e. a mix of the concept of pixel group and subsampling. Let's just drop the subsampling totally, as we can represent the subsamplings with a rectangular pixel group. So, now we have 'pixelspergroup' for each PixelFormat, which tells the width and height, in pixels and lines, of a pixel group. And for each plane, we have 'bytespergroup' which tells the number of bytes a pixel group takes horizontally on that plane, and 'linespergroup' which tells the number of lines a pixel group takes on that plane. Signed-off-by: Tomi Valkeinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we have horizontalsubsampling and verticalsubsampling. Then we had bytespergroup and verticalsubsampling, i.e. a mix of the concept of pixel group and subsampling.
Let's just drop the subsampling totally, as we can represent the subsamplings with a rectangular pixel group.
So, now we have 'pixelspergroup' for each PixelFormat, which tells the width and height, in pixels and lines, of a pixel group. And for each plane, we have 'bytespergroup' which tells the number of bytes a pixel group takes horizontally on that plane, and 'linespergroup' which tells the number of lines a pixel group takes on that plane.