Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian translation #60

Merged
merged 5 commits into from
Feb 10, 2022
Merged

Add Russian translation #60

merged 5 commits into from
Feb 10, 2022

Conversation

pepelsbey
Copy link
Contributor

Happy to help! 👋

Though it won’t be as easy as with other languages, I guess.

  1. I need to better understand what certain options do, to better translate them, see below.
  2. Some words needs to be inflected for proper grammar: 1 шаг, 2 шага, 5 шагов (1, 2, 5 steps). There is a lazy way of solving this: шаги: 1, 2, 5 (steps: 1, 2, 5), but requires some changes in templates too. Who knows, maybe there’s something in Intl.PluralRules() that might help.
  3. I wouldn’t specify country next to the language because Russian is multinational language. Also, ruRU doesn’t make much sense since AFAIK there are no other ru*.
  4. I intentionally kept original En strings in comments to ask some people from Russian community to review my translation.

Options that are unclear to me:

  • alphamax: Corner Threshold
  • minPathSegments: Min. Path Length
  • turnpolicy: Turn Policy
  • opttolerance: Optimisation Tolerance

I’d also suggest to rename keys in the single manner, probably camel-case:

  • 'hue-rotate' — hueRotate
  • turnpolicy — turnPolicy
  • opticurve — optiCurve
  • opttolerance — optTolerance (or optiTolerance?)

I can file a separate issue if you’d like.

@tomayac
Copy link
Owner

tomayac commented Feb 9, 2022

Happy to help! 👋

Thanks <3!

  1. Some words needs to be inflected for proper grammar: 1 шаг, 2 шага, 5 шагов (1, 2, 5 steps). There is a lazy way of solving this: шаги: 1, 2, 5 (steps: 1, 2, 5), but requires some changes in templates too. Who knows, maybe there’s something in Intl.PluralRules() that might help. Note that for now I don't even do this right for English (1 Steps). Can you, for now, roll with шага or шагов (the one that is less wrong the majority of the time) and we deal with solving this properly in a new PR that would fix the newly created Need to properly deal with plural rules in i18n.t() #62? It indeed looks like IntlPluralRules could help here.
  1. I wouldn’t specify country next to the language because Russian is multinational language. Also, ruRU doesn’t make much sense since AFAIK there are no other ru*.

I will remove the countries where they don't make sense. For now, can you leave it as is? I will deal with this in a separate PR that fixes #63.

  1. I intentionally kept original En strings in comments to ask some people from Russian community to review my translation.

Makes sense.

Options that are unclear to me:

  • alphamax: Corner Threshold
  • minPathSegments: Min. Path Length
  • turnpolicy: Turn Policy
  • opttolerance: Optimisation Tolerance

See the Potrace documentation for details.

I’d also suggest to rename keys in the single manner, probably camel-case:

  • 'hue-rotate' — hueRotate
  • turnpolicy — turnPolicy
  • opticurve — optiCurve
  • opttolerance — optTolerance (or optiTolerance?)

They are named the way Potrace names them. It's on purpose (but correct, it's inconsistent).

@tomayac
Copy link
Owner

tomayac commented Feb 9, 2022

You will notice that I have dealt with #63 and have adapted the PR accordingly. This will make your life a little easier.

@Marat-Tanalin
Copy link

Some words needs to be inflected for proper grammar: 1 шаг, 2 шага, 5 шагов (1, 2, 5 steps).

Fwiw, there is a table with compact plural-form algorithms for multiple languages.

@Zulcom
Copy link

Zulcom commented Feb 9, 2022

I am Russian native speaker and can confirm that this translations is correct, thanks @pepelsbey

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for frosty-lovelace-4cf67f ready!

🔨 Explore the source changes: 1222617

🔍 Inspect the deploy log: https://app.netlify.com/sites/frosty-lovelace-4cf67f/deploys/62050df04eb01200089f033f

😎 Browse the preview: https://deploy-preview-60--frosty-lovelace-4cf67f.netlify.app/

@tomayac
Copy link
Owner

tomayac commented Feb 10, 2022

Thank you all! <3 I think this can be merged in the current shape. Fine with you, @pepelsbey?

I will deal with the plural rules in #62, so for now let's just go with the plural form of "steps".

@pepelsbey pepelsbey marked this pull request as ready for review February 10, 2022 13:56
@pepelsbey pepelsbey closed this Feb 10, 2022
@pepelsbey pepelsbey reopened this Feb 10, 2022
@pepelsbey
Copy link
Contributor Author

Sorry, wrong button :) Yes, I think it’s good enough to be merged.

@tomayac
Copy link
Owner

tomayac commented Feb 10, 2022

Thank you all for collaborating on this! <3

@tomayac tomayac merged commit 1e32df2 into tomayac:main Feb 10, 2022
@pepelsbey pepelsbey deleted the add-russian branch February 10, 2022 23:05
@MeFoDy MeFoDy mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants