-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to lua 5.3 #116
base: master
Are you sure you want to change the base?
Switch to lua 5.3 #116
Conversation
Tests weren't passing because I used |
I'm leaving this PR open for a little while in order to make sure that there is no opposition to it that I may not be aware of. |
Would this impact any people using hlua with luajit? |
@TyOverby The lua API is backward-compatible, so it shouldn't have any impact. However lua 5.3 supports closures, which we may want to support in hlua eventually. If we do so then you'd get linking errors with luajit. |
Could you use crate features for Lua versions? It would require more restructuring but it would make the crate more available in the future. |
@SnirkImmington I've looked into it, and I think it should be done directly in a If we release both a |
No, there are usually a few breaking changes and incompatibilities between each version. Each of 5.1, 5.2 and 5.3 should be thought of as separate, but related languages. Similar to Python 2 vs 3. However since Lua is such a small language, it is usually not too much work to be compatible with a few versions.
Lua has supported closures for a long time, since 3.1 according to the version history page. |
Tests aren't passing for an unknown reason.