fix(gamestate): leave being called on push state

tomaisthorpe · Sep 24, 2023 · 12311cc · 12311cc
1 parent 48bf8e5
commit 12311cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/green-stingrays-melt.md b/.changeset/green-stingrays-melt.md
@@ -0,0 +1,5 @@
+---
+'@tedengine/ted': minor
+---
+
+Fix 'leave' triggered on game state push
diff --git a/packages/ted/src/core/game-state-manager.ts b/packages/ted/src/core/game-state-manager.ts
@@ -25,7 +25,9 @@ export default class TGameStateManager {
 
   /**
    * Pushes a new state onto the stack.
-   * Triggers [[`TGameState.onLeave`]] on the previously active state, then [[`TGameState.onEnter`]] on the new state.
+   * It triggers [[`TGameState.onEnter`]] on the new state.
+   *
+   * It does not trigger [[`TGameState.onLeave`]] on previously active state.
    *
    * @param name state name
    * @param args args to pass to the resumed state
@@ -37,8 +39,6 @@ export default class TGameStateManager {
       throw new Error(`Game State '${name}' does not exist`);
     }
 
-    await this.current()?.leave(this.engine);
-
     // If state hasn't been created, then create it
     if (!this.states[name]) {
       await this.createState(name);