Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Version of ReTerm to Latest #865

Draft
wants to merge 6 commits into
base: testing
Choose a base branch
from

Conversation

Willmac16
Copy link

  • Changelog of ReTerm between these two releases

  • I tested with toltecmk. The generated .ipk file installed fine and fixed the inverted colors issue I was having with the original version (also possible removed the duplicate icons in oxide).

@Eeems
Copy link
Member

Eeems commented May 27, 2024

What OS version did you test on? The testing branch is in the middle of adding 3.3.2 support, so I'll need to verify that it works on 3.3.2 against toltec testing before I merge. I'm also holding off on merging anything until the stable merge is done for ease of testing the stable merge stuff.

@Eeems Eeems added the packages Add or improve packages of the repository label May 27, 2024
@Willmac16
Copy link
Author

What OS version did you test on? The testing branch is in the middle of adding 3.3.2 support, so I'll need to verify that it works on 3.3.2 against toltec testing before I merge. I'm also holding off on merging anything until the stable merge is done for ease of testing the stable merge stuff.

This was on 3.3.2.1666 against testing

@Eeems
Copy link
Member

Eeems commented May 27, 2024

Alright, this will also need to be tested again 2.15. I'll try to take some time after I get the stable merge accross the finish line to validate on both my devices.

@Willmac16
Copy link
Author

Alright, this will also need to be tested again 2.15. I'll try to take some time after I get the stable merge accross the finish line to validate on both my devices.

Although, you can't actually use ReTerm on 2.0 or the rM1 because neither have support for the folio keyboard. So maybe changing the supported device/firmware string would be more apt.

@Eeems
Copy link
Member

Eeems commented May 27, 2024

Although, you can't actually use ReTerm on 2.0 or the rM1 because neither have support for the folio keyboard. So maybe changing the supported device/firmware string would be more apt.

You can connect an external keyboard, or pipe evdev input through to the device via various methods on the rM1, which is why I added ReTerm with both rM1 and rM2 support.

@Willmac16
Copy link
Author

Oh cool!

@Eeems Eeems added this to the 2024-W23 Merge Window milestone May 30, 2024
@Eeems
Copy link
Member

Eeems commented Jun 5, 2024

fb

When attempting to run this on a rM2 running 2.15.1.1189

@Eeems
Copy link
Member

Eeems commented Jun 5, 2024

Same error on the rM1

Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update makes ReTerm no longer compatible with 2.15 on either device. This will need to be reworked to provide the older version of ReTerm on 2.x, and the newer one on 3.x.

This would also require testing what happens when you downgrade with it installed and then reenable toltec.

@Eeems Eeems removed this from the 2024-W23 Merge Window milestone Jun 5, 2024
@Willmac16
Copy link
Author

Is it worth it to figure out/do you know why the changes break 2.0 support?

Also, it looks like you made changes to the package file inside the ReTerm repo, do those need to be propagated into this instance of the package file.

@Eeems
Copy link
Member

Eeems commented Jun 9, 2024

Is it worth it to figure out/do you know why the changes break 2.0 support?

It looks to be an intentional change to have the application stop if no keyboard is detected.

Also, it looks like you made changes to the package file inside the ReTerm repo, do those need to be propagated into this instance of the package file.

They may be worth including. I haven't looked at what the changes were.

@Eeems Eeems marked this pull request as draft September 14, 2024 16:57
@Eeems
Copy link
Member

Eeems commented Sep 14, 2024

I've marked this as a draft, as it will need to be reworked to split the package into the OS 2.x and OS 3.x versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants