Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable merge for week 34 of 2022 #619

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Stable merge for week 34 of 2022 #619

merged 8 commits into from
Sep 26, 2022

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Aug 21, 2022

New Packages

Updated Packages

  • yaft - 0.0.7-1 (Update yaft to v0.0.7 and add rM1 input patch #613)
    • Fix input on rM1
    • Update to 0.0.7
  • koreader - 2022.07-1 (Update KOReader to v2022.07 #609)
  • erode fret oxide rot tarnish decay corrupt anxiety - 2.4-1 (Update Oxide to v2.4 #603)
    • Opt-in crash reporting
    • Fixed issue where launcher will crash if a notification is removed with the API instead of through the UI
    • Fixed issue where the task switcher background will disappear if you close an application
    • Fixed issue where applications will be imported even though the file isn't executable, and thus would fail to launch

TheLastZombie and others added 6 commits August 21, 2022 12:03
* add ripgrep

Co-authored-by: gbyl <[email protected]>
* add package: lf

Co-authored-by: gbyl <[email protected]>
Co-authored-by: Nathaniel van Diepen <[email protected]>
* upgrade to yaft-v0.0.7

* add rm1 input patch

* update docker image version

Co-authored-by: gbyl <[email protected]>
@Eeems Eeems added the merge Weekly merge of the testing branch into the stable branch label Aug 21, 2022
@Eeems Eeems changed the title Merge/2022 w34 Stable merge for week 34 of 2022 Aug 21, 2022
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on rM 2.

rmfm starts fine from ssh, but does nothing when launched through remux.

Aug 21 20:29:21 reMarkable remux[8136]: env: can't execute 'node': No such file or directory

Given that node exists at /opt/bin/node I would guess that remux is missing or not transferring a PATH variable containing /opt/bin.

A quick temporary fix is to change/patch the shebang in /opt/bin/rmfm:

-#!/usr/bin/env node
+#!/opt/bin/node

For the long term, this should probably be adressed in remux (@raisjn).

Launching the app failes anyway though. I'm not sure here, but maybe node expects a full tty?

Aug 21 20:57:59 reMarkable remux[614]: /opt/bin/rmfm:52
Aug 21 20:57:59 reMarkable remux[614]:   output = output.stdout.toString().trim();
Aug 21 20:57:59 reMarkable remux[614]:                          ^
Aug 21 20:57:59 reMarkable remux[614]: TypeError: Cannot read property 'toString' of null
Aug 21 20:57:59 reMarkable remux[614]:     at ls (/opt/bin/rmfm:52:26)
Aug 21 20:57:59 reMarkable remux[614]:     at Object.<anonymous> (/opt/bin/rmfm:402:1)
Aug 21 20:57:59 reMarkable remux[614]:     at Module._compile (internal/modules/cjs/loader.js:1085:14)
Aug 21 20:57:59 reMarkable remux[614]:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
Aug 21 20:57:59 reMarkable remux[614]:     at Module.load (internal/modules/cjs/loader.js:950:32)
Aug 21 20:57:59 reMarkable remux[614]:     at Function.Module._load (internal/modules/cjs/loader.js:790:12)
Aug 21 20:57:59 reMarkable remux[614]:     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
Aug 21 20:57:59 reMarkable remux[614]:     at internal/main/run_main_module.js:17:47

Edit: The above issue seems to have the same root cause. output refers to running simple which is most likely not in $PATH either.

Edit: The other packages work fine.

@Eeems
Copy link
Member Author

Eeems commented Aug 21, 2022

@LinusCDE could you make the rmfm package maintainer aware of the issues you found?

@LinusCDE
Copy link
Member

The thing is, I'm not sure if this is on the project maintainer to actually fix. His implementation is totally okay.

This should be fixed in remux, as apps launched from opkg should have access to the paths in /opt.

I tested a little, and it would probably be the easiest to add a patch for the rmfm package until it is fixed in remux.

With this, remux can launch rmfm fine:

-#!/usr/bin/env node
+#!/opt/bin/node
+process.env.PATH += ":/opt/bin"

@LinusCDE
Copy link
Member

I'm creating a PR for patching this in as well as an issue for remux.

@LinusCDE
Copy link
Member

Hotfix is created and tested to be working: #620

Including this here will fix rmfm for remux.

New remux issue: rmkit-dev/rmkit#177

* Update Oxide to v2.4

* Update build image

* Fix libsentry dependency version

Co-authored-by: Linus K <[email protected]>
LinusCDE added a commit that referenced this pull request Aug 22, 2022
* Add path fix as mentioned in #619

* Fix patch problems and bump version
* Add path fix as mentioned in #619

* Fix patch problems and bump version
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, this should be good to go then.

Since I reviewed the oxide changes, I would consider them to be fine as well.

@Eeems Eeems merged commit 9d68c04 into stable Sep 26, 2022
@Eeems Eeems deleted the merge/2022-W34 branch September 26, 2022 16:53
RobotCaleb pushed a commit to RobotCaleb/toltec that referenced this pull request Sep 27, 2022
* Add path fix as mentioned in toltec-dev#619

* Fix patch problems and bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Weekly merge of the testing branch into the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants