Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include warning from the website #476

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Update README to include warning from the website #476

merged 2 commits into from
Oct 22, 2021

Conversation

J-MR-T
Copy link
Contributor

@J-MR-T J-MR-T commented Oct 21, 2021

Well I just soft-bricked my remarkable 2 because I followed the instructions here, which could have been avoided if the README contained the same warning as the Website.

I am pretty sure your "pull requests to stable cannot be accepted" rule does not apply to README updates, but if thats not the case then I'll create another one for testing.

Well I just soft-bricked my remarkable 2 because I followed the instructions here, which could have been avoided if the README contained the same warning as the Website.
@LinusCDE
Copy link
Member

Whether changes of the readme to stable are accepted I'm unsure.

I've installed toltec on my rM 2 with 2.10 support. As long as rm2fb is not installed, it shouldn't softbrick the device. The problem is, that for every release, rm2fb needs updated signatures to work properly or xochitl won't start. The issue is updating rm2fb (or just the signatures) fast enough and there are ongoing discussions about this in issue #445 and pr #461 on updating the signatures of rm2fb faster without waiting on a new release of the software. I think there were more discussions, but I'm unsure where or if just in discord).

In general I approve of adding this disclaimer for now. But I think we should have a more generalized disclaimer, that

Side note: rm2fb "only" bricks the selected launcher/xochitl from starting up if on an unsupported version and ssh should still work (at least over usb). PR #455 should resolve this issue in the future.

As said, I'm unsure whether changes to stable are accepted for the readme but find it logical as well. @Eeems or @matteodelabre, if this is okay, I would suggest merging this.

@J-MR-T
Copy link
Contributor Author

J-MR-T commented Oct 21, 2021

Side note: rm2fb "only" bricks the selected launcher/xochitl from starting up if on an unsupported version and ssh should still work (at least over usb). PR #455 should resolve this issue in the future.

Yes, I fortunately managed to get back into it via ssh and uninstall toltec again, after the reboot it worked again :D

@Eeems
Copy link
Member

Eeems commented Oct 21, 2021

@LinusCDE the following will make it so we don't really need to have a warning anymore after upgrades:

It's probably fine to add to the stable readme for now, but it'll have to be removed after the next stable merge.

@matteodelabre thoughts?

@Eeems Eeems added the merge Weekly merge of the testing branch into the stable branch label Oct 21, 2021
@J-MR-T
Copy link
Contributor Author

J-MR-T commented Oct 21, 2021

It might also be advantageous to only have one place where the installation process is detailled to avoid such inconsistencies in the future. Maybe the website can just link to the installation part of the README?

@Eeems
Copy link
Member

Eeems commented Oct 21, 2021

It might also be advantageous to only have one place where the installation process is detailled to avoid such inconsistencies in the future. Maybe the website can just link to the installation part of the README?

I think it would make more sense to have the readme link to the website. That said, this isn't going to be an issue for much longer due to issues/prs that both @LinusCDE and I linked.

@J-MR-T
Copy link
Contributor Author

J-MR-T commented Oct 21, 2021

Well which way around the installation instructions are, is for you to decide, I also thought it could prevent similar issues in general.

@matteodelabre
Copy link
Member

I also had in mind of redirecting users to the website for install instructions. As a nice side effect it would also free us from having to maintain the bootstrap checksum manually in the readme. As a temporary solution I think it’s fine to merge this PR.

@Eeems
Copy link
Member

Eeems commented Oct 22, 2021

I'll update the next stable merge to include removing the warning.

@Eeems Eeems merged commit 42948cb into toltec-dev:stable Oct 22, 2021
@Eeems
Copy link
Member

Eeems commented Oct 22, 2021

I just realized that we just pushed 2.10 support.. maybe we should remove the warning now and remove it from the website? @matteodelabre

@J-MR-T J-MR-T deleted the patch-1 branch October 22, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Weekly merge of the testing branch into the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants