Use xochitl instead of remarkable-shutdown in rm2fb-server #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last software relase (2.6), new waveform modes were added to xochitl to make the pinch-to-zoom feature work. Unfortunately, the remarkable-shutdown binary was not updated to support those new waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a less smooth experience than without rm2fb, since the screen gets refreshed less frequently during the gesture. See: * <#322 (comment)> * <ddvk/remarkable2-framebuffer#56> To address this issue, this PR changes the rm2fb-server to preload the `/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in both the `rm2fb-server` command and `rm2fb.service`. A start condition is added to `rm2fb.service` to only start if the librm2fb_server library actually exists on the filesystem. This is to avoid having two concurrent xochitl processes running, as the loader ignores non-existent files provided in LD_PRELOAD. Test plan: * Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of the pinch-to-zoom gesture, and make sure no message of the form `Unable to complete update: invalid waveform ( 6 )` appears in the server process. * Check that the display continuously updates when using the pinch-to-zoom gesture, even if the `rm2fb.service` service is running and xochitl is started with `rm2fb-client xochitl`. * Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart `rm2fb.service`. The service should not start. Make sure that there’s no duplicate `xochitl` process in this case.
|
yes, it works fine but problematically remux is sending it SIGSTOP signals when remux runs because rm2fb now has the bin of 'xochitl' (since remux doesn't assume it is "owning" a process, it scans for all processes that use the bin specified in the draft file). |
|
Fixed this with a patch to the server library to overwrite |
raisjn
approved these changes
Apr 2, 2021
matteodelabre
added a commit
to ddvk/remarkable2-framebuffer
that referenced
this pull request
Apr 8, 2021
…b-server See #56 and toltec-dev/toltec#325 for context.
raisjn
pushed a commit
to ddvk/remarkable2-framebuffer
that referenced
this pull request
Apr 10, 2021
…fb-server (#59) See #56 and toltec-dev/toltec#325 for context.
danshick
pushed a commit
to danshick/toltec
that referenced
this pull request
May 5, 2021
…v#325) In the last software relase (2.6), new waveform modes were added to xochitl to make the pinch-to-zoom feature work. Unfortunately, the remarkable-shutdown binary was not updated to support those new waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a less smooth experience than without rm2fb, since the screen gets refreshed less frequently during the gesture. See: * <toltec-dev#322 (comment)> * <ddvk/remarkable2-framebuffer#56> To address this issue, this PR changes the rm2fb-server to preload the `/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in both the `rm2fb-server` command and `rm2fb.service`. This PR also contains a patch to prevent rm2fb-server from appearing as xochitl in process lists. This is done by overwriting `argv[0]` after the library is initialized. This is necessary to prevent remux from mistakenly killing rm2fb-server. A start condition is added to `rm2fb.service` to only start if the librm2fb_server library actually exists on the filesystem. This is to avoid having two concurrent xochitl processes running, as the loader ignores non-existent files provided in LD_PRELOAD. Test plan: * Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of the pinch-to-zoom gesture, and make sure no message of the form `Unable to complete update: invalid waveform ( 6 )` appears in the server process. * Check that the display continuously updates when using the pinch-to-zoom gesture, even if the `rm2fb.service` service is running and xochitl is started with `rm2fb-client xochitl`. * Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart `rm2fb.service`. The service should not start. Make sure that there’s no duplicate `xochitl` process in this case.
danshick
added a commit
to danshick/toltec
that referenced
this pull request
May 5, 2021
…oltec-dev#325)" This reverts commit aadaead.
LinusCDE
pushed a commit
that referenced
this pull request
Jun 3, 2021
In the last software relase (2.6), new waveform modes were added to xochitl to make the pinch-to-zoom feature work. Unfortunately, the remarkable-shutdown binary was not updated to support those new waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a less smooth experience than without rm2fb, since the screen gets refreshed less frequently during the gesture. See: * <#322 (comment)> * <ddvk/remarkable2-framebuffer#56> To address this issue, this PR changes the rm2fb-server to preload the `/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in both the `rm2fb-server` command and `rm2fb.service`. This PR also contains a patch to prevent rm2fb-server from appearing as xochitl in process lists. This is done by overwriting `argv[0]` after the library is initialized. This is necessary to prevent remux from mistakenly killing rm2fb-server. A start condition is added to `rm2fb.service` to only start if the librm2fb_server library actually exists on the filesystem. This is to avoid having two concurrent xochitl processes running, as the loader ignores non-existent files provided in LD_PRELOAD. Test plan: * Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of the pinch-to-zoom gesture, and make sure no message of the form `Unable to complete update: invalid waveform ( 6 )` appears in the server process. * Check that the display continuously updates when using the pinch-to-zoom gesture, even if the `rm2fb.service` service is running and xochitl is started with `rm2fb-client xochitl`. * Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart `rm2fb.service`. The service should not start. Make sure that there’s no duplicate `xochitl` process in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last software relase (2.6), new waveform modes were added to xochitl to make the pinch-to-zoom feature work. Unfortunately, the remarkable-shutdown binary was not updated to support those new waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a less smooth experience than without rm2fb, since the screen gets refreshed less frequently during the gesture.
See:
To address this issue, this PR changes the rm2fb-server to preload the
/usr/bin/xochitlbinary instead of/usr/bin/remarkable-shutdownin both therm2fb-servercommand andrm2fb.service.A start condition is added to
rm2fb.serviceto only start if the librm2fb_server library actually exists on the filesystem. This is toavoid having two concurrent xochitl processes running, as the loader ignores non-existent files provided in LD_PRELOAD.
Test plan:
rm2fb-serverandrm2fb-client xochitl, make use of the pinch-to-zoom gesture, and make sure no message of the formUnable to complete update: invalid waveform ( 6 )appears in the server process.rm2fb.serviceservice is running and xochitl is started withrm2fb-client xochitl./opt/lib/librm2fb_server.so.1symlink and restartrm2fb.service. The service should not start. Make sure that there’s no duplicatexochitlprocess in this case.