Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From trait for conversions between Clade, TelomereSeq and Seq #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lavafroth
Copy link

@lavafroth lavafroth commented Nov 21, 2023

Changes

  • Convert clades into enum
  • Use the strum crate for easy operations between the Clade enum and strings
  • Do not use heap allocate inner slice of a Seq
  • Implement From trait to convert Clade into Seq
  • Implement From trait to convert Clade into TelomereSeq
  • Removes redundant length field for TelomereSeq, now accessed through the len method of the seq field
  • Do not panic when parsing string as clade and getting the respective telomere sequence, return a result instead. Can aid with Make errors better & more informative #7

@Euphrasiologist
Copy link
Collaborator

Thanks for this - I will get around to looking at this. Just writing up tidk as a paper at the moment, so on a code freeze for a bit. I also need to think whether we should introduce more crates for this!

@lavafroth
Copy link
Author

lavafroth commented Dec 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants