feat: task improvements #2956
Open
feat: task improvements #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepan662
force-pushed
the
stepangranat/task-improvements3
branch
from
11ffb29 to
7de47fe
Compare
15 tasks
JanCizmar
requested changes
Mar 6, 2025
| @@ -559,8 +559,8 @@ class TaskService( | |||
| private fun createNotificationIfApplicable(task: Task) { | |||
| val notificationType = | |||
| when (task.state) { | |||
| TaskState.DONE -> NotificationType.TASK_COMPLETED | |||
| TaskState.CLOSED -> NotificationType.TASK_CLOSED | |||
| TaskState.FINISHED -> NotificationType.TASK_COMPLETED | |||
There was a problem hiding this comment.
Let's migrate also the notification types.
Also if you are in the migrating this, the TASKS_CREATE activity should be renamed to TASK_CREATE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #2778