Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --namespaces support to sync #140

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Dec 24, 2024

Add --namespaces configuration for sync, which has been discussed in #137.

With this new option is becomes possible to define for the sync command, which namespaces are handled by it.

If namespaces are defined:

  • New keys, which do not have a namespace attached, are not pushed anymore.
  • New keys, which do not belong a to defined namespace are not pushed.
  • Existing unused keys, which do not belong to a defined namespace are no longer deleted, when sync is used with --remove-unused.

The latter makes it possible for multiple applications to use the same project without knowing about all namespaces within that project, as outlined in the issue: #137

Builds on top of #139

@gu-stav gu-stav force-pushed the feat/sync-namespaces-support branch from c2261c6 to 9981bc1 Compare December 24, 2024 20:03
@gu-stav gu-stav changed the title feat(cli): add --namespaces support to sync feat: add --namespaces support to sync Dec 24, 2024
@stepan662
Copy link
Contributor

stepan662 commented Jan 22, 2025

I've tried to finish this here #151 , but I see an inconsistency with the push command. Where push command's --remove-unused removes all other keys (regardless of the namespace). Here however we would only delete unused keys within the given namespace.

This kind of inconsistency is potentially very confusing for the user. I think we could name it e.g. --namespaces-scope, or something like that. And also add --namespaces, but keep the same logic as is in push command. Later there could be also --namespaces-scope for the push command (the logic is implemented on BE, so it would be a bit more complicated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants