Fix deadlock with tracing-error + fmt::Subscriber
#2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `fmt::Debug` implementation contains a `Span` which tries to access the span's extensions, this can cause a deadlock if the extensions are already locked by the subscriber. This is circumvented by creating a string representation before the lock is held and then combining this representation with any that was in the span previously.
mladedav
requested review from
yaahc,
a team,
hawkw and
davidbarsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1565
Solution
I've added a method to the
FormatFieldsimplementation with a provided default implementation based on what was already in theadd_fieldsmethod. This is potentially a breaking change in a subtle manner as anyone who has manually implemented theadd_fieldsmethod will most likely also want to implement this.When fields should be printed, they are first printed to a new instance and then they are merged with the original.