Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracing-core] Remove `static requirement from Event #1048

Closed
wants to merge 34 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5868a6d
[WIP] Metadata name is Cow<'static, str>
dvdplm Sep 28, 2020
f40de7b
Fetch patch from git
dvdplm Sep 29, 2020
ed04e30
Clean up MockSpan
dvdplm Sep 29, 2020
645c133
Don't clone the name in Metadata::name
dvdplm Sep 30, 2020
5a69f07
Use Cow in assert_last_closed
dvdplm Sep 30, 2020
f922cc1
If Metadata is always used with a 'static lifetime it might make sens…
dvdplm Sep 30, 2020
fa4a808
cleanup
dvdplm Sep 30, 2020
183f75f
Merge branch 'master' into dp-use-cow
dvdplm Oct 5, 2020
97e5b31
Metadata.target is Cow – breaks AsLog impl
dvdplm Oct 6, 2020
028ae65
Make it build (ty Ben)
dvdplm Oct 6, 2020
a3661f8
Make tests pass
dvdplm Oct 6, 2020
f0a6443
Undo changes to TestTracer and patched opentelemetry, not needed
dvdplm Oct 6, 2020
a9a0568
Remove patch
dvdplm Oct 6, 2020
2ee5da9
cleanup
dvdplm Oct 6, 2020
d8afcbe
cleanup
dvdplm Oct 6, 2020
381d574
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 7, 2020
8913759
Store file as Cow
dvdplm Oct 7, 2020
b250109
Store module_path as Cow
dvdplm Oct 7, 2020
e29d3ca
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 16, 2020
79ffec0
WIP Event.metadata is Cow
dvdplm Oct 16, 2020
33ccbf5
Cleanup
dvdplm Oct 18, 2020
649fb74
Cleanup
dvdplm Oct 18, 2020
856a1d8
Event takes &'a Metadata<'b>
dvdplm Oct 18, 2020
9e3f4fe
No need to be Clone
dvdplm Oct 18, 2020
f7274dc
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 19, 2020
b3bec86
Feature gate usage of Cow in Metadata
dvdplm Oct 19, 2020
fda189b
Add constructor for dynamic data
dvdplm Oct 19, 2020
c46c352
No need for extra lifetime
dvdplm Oct 19, 2020
7b0dfe5
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 19, 2020
280f0bf
Use impl Into<Cow<'a, str>
dvdplm Oct 20, 2020
4225d96
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 22, 2020
e4c99b3
Merge branch 'dp-target-is-cow' into dp-event-non-static-metadata
dvdplm Oct 22, 2020
f42a644
Merge remote-tracking branch 'upstream/master' into dp-target-is-cow
dvdplm Oct 23, 2020
421e6d1
Merge branch 'dp-target-is-cow' into dp-event-non-static-metadata
dvdplm Oct 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracing-core/src/dispatch.rs
Original file line number Diff line number Diff line change
@@ -667,7 +667,7 @@ impl Dispatch {
/// [`event`]: super::collect::Collect::event
#[inline]
pub fn event<'a>(&'a self, event: &'a Event<'a, '_>) {
self.subscriber().event(event)
self.collector().event(event)
}

/// Records that a span has been can_enter.
2 changes: 1 addition & 1 deletion tracing-core/src/event.rs
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ pub struct Event<'a, 'b> {

impl<'a, 'b: 'a> Event<'a, 'b> {
/// Constructs a new `Event` with the specified metadata and set of values,
/// and observes it with the current subscriber.
/// and observes it with the current collector.
pub fn dispatch(metadata: &'a Metadata<'_>, fields: &'a field::ValueSet<'_>) {
let event = Event::new(metadata, fields);
crate::dispatch::get_default(|current| {
2 changes: 1 addition & 1 deletion tracing-journald/src/lib.rs
Original file line number Diff line number Diff line change
@@ -154,7 +154,7 @@ where
});
}

fn on_event(&self, event: &Event<'_, '_>, ctx: Context<S>) {
fn on_event(&self, event: &Event<'_, '_>, ctx: Context<C>) {
let mut buf = Vec::with_capacity(256);

// Record span fields
3 changes: 1 addition & 2 deletions tracing-subscriber/src/reload.rs
Original file line number Diff line number Diff line change
@@ -94,8 +94,7 @@ where
}

#[inline]
// fn on_event<'a>(&'a self, event: &'a Event<'a>, ctx: layer::Context<'_, S>) {
fn on_event(&self, event: &Event<'_, '_>, ctx: layer::Context<'_, S>) {
fn on_event(&self, event: &Event<'_, '_>, ctx: subscribe::Context<'_, C>) {
try_lock!(self.inner.read()).on_event(event, ctx)
}

9 changes: 4 additions & 5 deletions tracing-subscriber/src/subscribe.rs
Original file line number Diff line number Diff line change
@@ -326,9 +326,8 @@ where
// seems like a good future-proofing measure as it may grow other methods later...
fn on_follows_from(&self, _span: &span::Id, _follows: &span::Id, _ctx: Context<'_, C>) {}

/// Notifies this layer that an event has occurred.
// fn on_event<'a, 'b: 'a>(&'a self, _event: &'a Event<'a, 'b>, _ctx: Context<'_, S>) {}
fn on_event(&self, _event: &Event<'_, '_>, _ctx: Context<'_, S>) {}
/// Notifies this subscriber that an event has occurred.
fn on_event(&self, _event: &Event<'_, '_>, _ctx: Context<'_, C>) {}

/// Notifies this subscriber that a span with the given ID was entered.
fn on_enter(&self, _id: &span::Id, _ctx: Context<'_, C>) {}
@@ -771,7 +770,7 @@ where
}

#[inline]
fn on_event(&self, event: &Event<'_, '_>, ctx: Context<'_, S>) {
fn on_event(&self, event: &Event<'_, '_>, ctx: Context<'_, C>) {
self.inner.on_event(event, ctx.clone());
self.subscriber.on_event(event, ctx);
}
@@ -862,7 +861,7 @@ where
}

#[inline]
fn on_event(&self, event: &Event<'_, '_>, ctx: Context<'_, S>) {
fn on_event(&self, event: &Event<'_, '_>, ctx: Context<'_, C>) {
if let Some(ref inner) = self {
inner.on_event(event, ctx);
}
4 changes: 2 additions & 2 deletions tracing/tests/filter_caching_is_lexically_scoped.rs
Original file line number Diff line number Diff line change
@@ -37,8 +37,8 @@ fn filter_caching_is_lexically_scoped() {
let count = Arc::new(AtomicUsize::new(0));
let count2 = count.clone();

let subscriber = subscriber::mock()
.with_filter(move |meta| match meta.name().as_ref() {
let subscriber = collector::mock()
.with_filter(move |meta| match meta.name() {
"emily" | "frank" => {
count2.fetch_add(1, Ordering::Relaxed);
true
Original file line number Diff line number Diff line change
@@ -33,8 +33,8 @@ fn filters_are_not_reevaluated_for_the_same_span() {
let alice_count2 = alice_count.clone();
let bob_count2 = bob_count.clone();

let (subscriber, handle) = subscriber::mock()
.with_filter(move |meta| match meta.name().as_ref() {
let (collector, handle) = collector::mock()
.with_filter(move |meta| match meta.name() {
"alice" => {
alice_count2.fetch_add(1, Ordering::Relaxed);
false