Add some tests for Limit, BytesMut and Reader #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
May 23, 2025
tests/test_bytes.rs
Outdated
| @@ -186,6 +186,13 @@ fn split_off_oob() { | |||
| let _ = hello.split_off(44); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[should_panic] | |||
There was a problem hiding this comment.
Can you add the panic message here?
Suggested change
| #[should_panic] | |
| #[should_panic = "whatever the error is"] |
paolobarbolini
suggested changes
May 23, 2025
tests/test_limit.rs
Outdated
|
|
||
| #[test] | ||
| #[should_panic] | ||
| fn limit_advanve_mut_panic_2() { |
There was a problem hiding this comment.
Suggested change
| fn limit_advanve_mut_panic_2() { | |
| fn limit_advance_mut_panic_2() { |
tests/test_limit.rs
Outdated
|
|
||
| #[test] | ||
| #[should_panic] | ||
| fn limit_advanve_mut_panic_1() { |
There was a problem hiding this comment.
Suggested change
| fn limit_advanve_mut_panic_1() { | |
| fn limit_advance_mut_panic_1() { |
…rror for limit_advance_mut_panic
Darksonn
reviewed
May 24, 2025
tests/test_limit.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| #[should_panic] |
There was a problem hiding this comment.
Can you add messages to all of them? Thanks!
There was a problem hiding this comment.
Thanks for your correction and thanks for your time to review my PR!
There was a problem hiding this comment.
Hi @Darksonn 👋, thank you for the review!
I’ve updated the code based on your suggestions. If there are any further changes needed, please let me know!😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your time to review this PR.
By examing the existing code, we found that some tests can be added to improve the repo's overall test coverage. The tests we submitted have been carefully curated by us to ensure their behavior and effectiveness.
The code region we covered is:
limit.rs:
limit.rs
reader.rs:
bytes/src/buf/reader.rs
Lines 40 to 42 in d9d5c59
bytes_mut.rs:
bytes/src/bytes_mut.rs
Lines 323 to 325 in d9d5c59
And while testing the Limit implementation, I noticed that when both Limit and BytesMut are introduced, calling the limit method on a Limit<&mut [u8]> object would by default invoke the limit method from BytesMut. This behavior seems somewhat counterintuitive to me. I'm not certain whether this needs to be addressed, but I thought I'd mention it for awareness.
link
Thanks again for reviewing.