Rename hex_impl! to fmt_impl! and reuse it for fmt::Debug #743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
fmt
module there are two submodules:debug
- Implementingfmt::Debug
hex
- Implementingfmt::LowerHex
,fmt::UpperHex
Both implement core logic for
BytesRef<'_>
, but later one used a macro to propagate it toBytes
andBytesMut
while other did it manually. This PR fixes that.Macro imports in rust edition 2018 are limited. Therefore - I needed to first define a macro in a super module and later add
#[macro_use]
attribute to submodules.I've tested that this solution does not leak the macro to the library public interface or docs.
Saves 9 lines of code ;)
16 insertions(+), 25 deletions(-)