Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unnecessary else #662

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Remove an unnecessary else #662

merged 1 commit into from
Jan 28, 2024

Conversation

braddunbar
Copy link
Contributor

The if block above always returns, acting as a guard, so there's no reason for an else here.

@braddunbar
Remove an unnecessary else
10ca02f 
The if block above always returns, acting as a guard, so there's no
reason for an else here.
maminrayej
maminrayej approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks.

@maminrayej maminrayej merged commit 9257a6e into tokio-rs:master Jan 28, 2024
15 checks passed
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
Merged
@braddunbar braddunbar deleted the unnecessary-else branch March 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maminrayej maminrayej maminrayej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braddunbar @maminrayej