Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use let-else in buf_get_impl #641

Closed
wants to merge 1 commit into from

Conversation

braddunbar
Copy link
Contributor

I think let-else is a bit more explicit here.

I think let-else is a bit more explicit here.
@taiki-e
Copy link
Member

taiki-e commented Dec 19, 2023

Closing because let-else is not available on our MSRV.

Thanks anyway for the PR.

@taiki-e taiki-e closed this Dec 19, 2023
@seanmonstar
Copy link
Member

This would require a newer rustc. Even if it were within policy to pick one that supports this syntax, I wouldn't want us to do that just for a syntax change. I lean towards only upgrading MSRV when it will provide a useful improvement to users.

@braddunbar
Copy link
Contributor Author

Ah! That makes a lot of sense. Thank you for the response! 🙏

@braddunbar braddunbar deleted the let-else branch December 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants