add IntoResponse impl on custom Json extractor example #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also let the endpoint echo back the parsed json request body closes tokio-rs#2186
|
Oh, new clippy lints and an ICE from @lennart to be clear, none of this is related to your PR. We'll fix it separately and merge your PR afterwards. |
davidpdrsn
approved these changes
Aug 22, 2023
|
CI should pass if you merge the latest main. |
|
No it won't, my PR was incomplete. It only fixed clippy, not cargo-public-api-crates. See also what I sent you on Discord 😅 |
|
Oh okay. I’m afk right now but will check later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current custom-extractor-error/derive_from_requst example does not allow the wrapped
Jsonextractor to be used as a response.Solution
Adding an impl for
IntoResponsefor the custom extractor provides the same ergonomics as the originalaxum::Json.NOTE: the example now also echoes back the parsed json request body (which it wasn't before and therefore the code did compile without the
impl)edit(jplatte): Closes #2186.