Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #2162

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Improve CI #2162

merged 3 commits into from
Aug 8, 2023

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Aug 8, 2023

cc @weiznich re. first commit.

@jplatte jplatte marked this pull request as ready for review August 8, 2023 08:41
@jplatte jplatte requested a review from davidpdrsn August 8, 2023 09:06
davidpdrsn
davidpdrsn approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jplatte jplatte merged commit 4120195 into main Aug 8, 2023
18 checks passed
@jplatte jplatte deleted the jplatte/ci branch August 8, 2023 09:27
@weiznich
Copy link
Contributor

weiznich commented Aug 8, 2023

Thanks for the ping. I currently work on rust-lang/rust#114452 which should replace the internal attribute and hopefully is usable on stable someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplatte @weiznich @davidpdrsn