Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty path capture docs and tests #2127

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Add empty path capture docs and tests #2127

merged 2 commits into from
Aug 2, 2023

Conversation

kriswuollett
Copy link
Contributor

Fixes: #2126

Motivation

Inform users that empty path segment capture is possible.

Solution

Update path segment capture docs and add unit tests to demo and confirm it works.

davidpdrsn
davidpdrsn approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit e4865e1 into tokio-rs:main Aug 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs and tests should cover empty path segment capture
2 participants
@kriswuollett @davidpdrsn