-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide 'app' to '--run' lambda. #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -75,6 +103,10 @@ class Command: | |||
The $help is a longer description of the command that can span multiple lines. Use | |||
indented lines to continue paragraphs (just like toitdoc). The first paragraph of the | |||
$help is used as short help, and should have meaningful content on its own. | |||
|
|||
The $run callback is invoked when the command is executed. It is given the $App and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree with the chosen order here (app before parsed), but it would probably have caused less churn to add the app as the last parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed.
I think it's relatively easy to fix, though. So hopefully it won't really be a huge issue.
No description provided.