Only request human output for non-result in the JSON UI. (#72)

toitlang · Oct 4, 2024 · 94eee76 · 94eee76
1 parent f893664
commit 94eee76
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/ui.toit b/src/ui.toit
@@ -732,6 +732,9 @@ class JsonPrinter extends HumanPrinterBase:
   needs-structured --kind/int -> bool:
     return kind == Ui.RESULT
 
+  wants-human --kind/int -> bool:
+    return kind != Ui.RESULT
+
   print_ str/string:
     print-on-stderr_ str
 

diff --git a/tests/ui-test.toit b/tests/ui-test.toit
@@ -370,3 +370,10 @@ test-json:
   ui.emit --error "some error"
   expect-equals "Error: some error\n" printer.stderr
   printer.reset
+
+  expect ui.wants-structured  // By default the kind is "Ui.RESULT".
+  expect (ui.wants-structured --kind=Ui.RESULT)
+  expect-not (ui.wants-structured --kind=Ui.INFO)
+  expect-not ui.wants-human  // By default the kind is "Ui.RESULT".
+  expect-not (ui.wants-human --kind=Ui.RESULT)
+  expect (ui.wants-human --kind=Ui.INFO)