Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/time series #119

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Feature/time series #119

wants to merge 46 commits into from

Conversation

neznayer
Copy link
Contributor

  • params を doc に合わせました
  • バグフィックス

neznayer added 30 commits July 7, 2022 19:12
@neznayer
edit metadata.json according to new params names
5afae21
@neznayer
add validateParams.js
9b66c53
@neznayer
brushing working
a84290d
@neznayer
change to use d3.brush 1
69aa755
@neznayer
working with brushes and ordinal x axis
8c5b4d4
@neznayer
add linear scale
0c8a1b1
@neznayer
smooth scaling for linear scale
09589a0
@neznayer
time scale working
241aad8
@neznayer
preview chart scale bug fix
2799b09
@neznayer
remove console.log
5e5eabb 
change to const
@neznayer
add error, log scale
5e30e5e
@neznayer
add Ledend2(temporary), legend
599f043
@neznayer
add range settings
00dc27c
@neznayer
bugfix excessive legend append
b0d144a
@neznayer
fix y range bug
991ca3c 
fix line func

fix liine fn
@neznayer
add hide ticks, hide axes support
fd780f3
@neznayer
fix preview widths bug
338dd4a
@neznayer
imverr preview selection
90b718e
@neznayer
update readme, structuredClone values
1ec0ac3
@neznayer
fix json, fix eslint error
5d190e1
@neznayer
previewX & Y axis with no ticks
7a4c495
@neznayer
add error bars - added
70b5b19
@neznayer
add error bars
6c7614f
@neznayer
symbols working
c8795dc
@neznayer
error bars ok
4cb747c
@neznayer
gridlines wip
f7c6628
@neznayer
add gridlines y, add error check
835c59b
@neznayer
wip
8000eda
@neznayer
bug with ordinal scale and error bars fixed
bb55d8e
@neznayer
add custom handles, ledend fix
34beddd
@neznayer neznayer requested a review from penqe October 31, 2022 05:57
penqe
penqe reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題はないのですが、気づいたことをコメントしました。

stanzas/linechart-d3/style.scss Outdated Show resolved Hide resolved
penqe
penqe approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

penqe
penqe approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@penqe penqe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

（一度レビューしてましたね。。）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penqe penqe penqe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neznayer @penqe