-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ForceGraph/fix selection #140
Conversation
neznayer
commented
May 29, 2024
•
edited
Loading
edited
- 選択のCSSを修正
- 微量リファクタリング
…hord-diagram-selections
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ed64e70
to
5c05969
Compare
…ections ChordDiagram/Fix selected style, bugfix classes
…e-graph-selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントしました。lintのエラーも出てるようです
.style("fill", (d) => chords.groups[d.source.index].color); | ||
.style("fill", (d) => chords.groups[d.source.index][symbols.nodeColorSym]); | ||
|
||
console.log("ribbons", ribbons); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console が残ってます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
失礼しました。console を削除しました。 lint エラーをも修正しました。
(こちらは、npm run lint
で出ていたエラーは2個があって、一個はchord diagram ともう一つは pagination table 関係らしいなので、 chord diagram 関係のものだけを修正しました)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。確認できました。