Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceGraph/fix selection #140

Merged
merged 17 commits into from
May 30, 2024
Merged

ForceGraph/fix selection #140

merged 17 commits into from
May 30, 2024

Conversation

neznayer
Copy link
Contributor

@neznayer neznayer commented May 29, 2024

Force chart selection

  • 選択のCSSを修正
  • 微量リファクタリング

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metastanza-devel ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 8:31am

@neznayer neznayer force-pushed the feature/fix-force-graph-selection branch from ed64e70 to 5c05969 Compare May 29, 2024 08:28
@neznayer neznayer changed the title Feature/fix force graph selection ForceGraph/fix selection May 29, 2024
@neznayer neznayer marked this pull request as ready for review May 30, 2024 04:15
@neznayer neznayer requested a review from penqe May 30, 2024 04:17
Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました。lintのエラーも出てるようです

.style("fill", (d) => chords.groups[d.source.index].color);
.style("fill", (d) => chords.groups[d.source.index][symbols.nodeColorSym]);

console.log("ribbons", ribbons);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console が残ってます

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失礼しました。console を削除しました。 lint エラーをも修正しました。
(こちらは、npm run lint で出ていたエラーは2個があって、一個はchord diagram ともう一つは pagination table 関係らしいなので、 chord diagram 関係のものだけを修正しました)

Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。確認できました。

@penqe penqe merged commit 280ee28 into dev May 30, 2024
6 checks passed
@penqe penqe deleted the feature/fix-force-graph-selection branch May 30, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants