Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and stop instance method #9

Merged
merged 10 commits into from
Aug 7, 2023
Merged

Add start and stop instance method #9

merged 10 commits into from
Aug 7, 2023

Conversation

clam004
Copy link
Collaborator

@clam004 clam004 commented Aug 7, 2023

Issue https://github.com/orgs/togethercomputer/projects/2/views/2?pane=issue&itemId=31987006

Added to the python package and CLI:

  1. a method to list all running (started) and stopped model instances.
  2. a method to start a model instance using its name from the list.
  3. a method to stop a model instance using its name from the list.

Replaced the instructions to the user in the README to go start their model in their browser on the playground, to giving the option of handling start and stop from their command line or python IDE.

@clam004 clam004 requested review from csris and orangetin August 7, 2023 05:37
@clam004 clam004 closed this Aug 7, 2023
@clam004 clam004 reopened this Aug 7, 2023
Copy link
Member

@orangetin orangetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the CLI should only print started instances by default? I've left a suggestion for how to do this. But the rest looks good!

src/together/commands/models.py Show resolved Hide resolved
src/together/commands/models.py Outdated Show resolved Hide resolved
Copy link
Member

@orangetin orangetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clam004 clam004 merged commit c8dc48f into main Aug 7, 2023
1 check passed
@orangetin orangetin deleted the start-stop branch August 7, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants