Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): incorrect presentation order #8840

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(edgeless): incorrect presentation order #8840

merged 1 commit into from
Dec 6, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Dec 2, 2024 •
edited
Loading

Close BS-1622

What changes

  • added presentationIndex to fix issues about presentation order
  • add signal watcher to frame-panel and the frame menu of presentation-toolbar
  • add tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea998b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:28am

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@L-Sun Graphite App
Copy link
Contributor Author

L-Sun commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ea998b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@L-Sun L-Sun marked this pull request as ready for review December 2, 2024 16:08
@L-Sun L-Sun requested a review from a team as a code owner December 2, 2024 16:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.09 MB (+0.02% 🔺)
@blocksuite/affine/block-std 156.68 KB (0%)
@blocksuite/affine/block-std/gfx 80.58 KB (+0.18% 🔺)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.87 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.24 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.89 MB (+0.03% 🔺)
@blocksuite/affine/blocks 1.98 MB (+0.04% 🔺)
@blocksuite/affine/blocks/schemas 88.76 KB (+0.08% 🔺)

@L-Sun L-Sun force-pushed the l-sun/fix/frame-pre-order branch from 8d815ac to c939f68 Compare December 2, 2024 16:15
@L-Sun L-Sun force-pushed the l-sun/fix/frame-pre-order branch from 04b8ac6 to e47ab81 Compare December 3, 2024 02:49
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 6, 2024 •
edited
Loading

Merge activity

@L-Sun
fix(edgeless): incorrect presentation order (#8840)
ea998b4 
Close [BS-1622](https://linear.app/affine-design/issue/BS-1622/frame-的排序功能修复-and-rfc)

### What changes
- added `presentationIndex` to fix issues about presentation order
- add signal watcher to `frame-panel` and the frame menu of `presentation-toolbar`
- add tests
@L-Sun L-Sun force-pushed the l-sun/fix/frame-pre-order branch from 659e986 to ea998b4 Compare December 6, 2024 07:26
@graphite-app graphite-app bot merged commit ea998b4 into master Dec 6, 2024
36 checks passed
@graphite-app graphite-app bot deleted the l-sun/fix/frame-pre-order branch December 6, 2024 07:31
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Merged
OlegDev1 pushed a commit to OlegDev1/blocksuite that referenced this pull request Dec 7, 2024
@L-Sun @OlegDev1
fix(edgeless): incorrect presentation order (toeverything#8840)
dc610ee 
Close [BS-1622](https://linear.app/affine-design/issue/BS-1622/frame-的排序功能修复-and-rfc)

### What changes
- added `presentationIndex` to fix issues about presentation order
- add signal watcher to `frame-panel` and the frame menu of `presentation-toolbar`
- add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@L-Sun L-Sun

Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Sun @doodlewind