Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linked doc supports aliases #8806

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 26, 2024

Closes: BS-1946

What's Changed!

  • extends ReferenceInfo, adding two new fields: title and description
  • adds Copy and Edit buttons to toolbar
    • Copy: copy link
    • Edit: custom title and description
  • organizes embed models and components, distinguish between external and internal

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 266b528

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:34am

Copy link

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Nov 26, 2024

Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 266b528. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.1 MB (+0.23% 🔺)
@blocksuite/affine/block-std 156.64 KB (-0.03% 🔽)
@blocksuite/affine/block-std/gfx 80.58 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.87 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.24 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.89 MB (+0.16% 🔺)
@blocksuite/affine/blocks 1.99 MB (+0.13% 🔺)
@blocksuite/affine/blocks/schemas 88.82 KB (+0.08% 🔺)

@fundon fundon force-pushed the fundon/11_26_feat_linked_doc_alias branch 2 times, most recently from e5829fd to 84efad7 Compare December 5, 2024 12:21
Copy link
Member

doodlewind commented Dec 6, 2024

Merge activity

  • Dec 6, 2:27 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 6, 2:27 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 6, 2:37 AM EST: A user merged this pull request with the Graphite merge queue.

@fundon fundon removed the merge label Dec 6, 2024
Closes: [BS-1946](https://linear.app/affine-design/issue/BS-1946/实现-inlinecardembed-view-alias-功能)

### What's Changed!

* extends `ReferenceInfo`, adding two new fields: `title` and `description`
* adds `Copy` and `Edit` buttons to toolbar
  * `Copy`: copy link
  * `Edit`: custom title and description
* organizes embed models and components, distinguish between external and internal
@doodlewind doodlewind force-pushed the fundon/11_26_feat_linked_doc_alias branch from c23ea9e to 266b528 Compare December 6, 2024 07:32
@doodlewind doodlewind added merge and removed merge labels Dec 6, 2024
@graphite-app graphite-app bot merged commit 266b528 into master Dec 6, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/11_26_feat_linked_doc_alias branch December 6, 2024 07:37
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
OlegDev1 pushed a commit to OlegDev1/blocksuite that referenced this pull request Dec 7, 2024
Closes: [BS-1946](https://linear.app/affine-design/issue/BS-1946/实现-inlinecardembed-view-alias-功能)

### What's Changed!

* extends `ReferenceInfo`, adding two new fields: `title` and `description`
* adds `Copy` and `Edit` buttons to toolbar
  * `Copy`: copy link
  * `Edit`: custom title and description
* organizes embed models and components, distinguish between external and internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants