fix(store): add dispose method to collection (#8852)

toeverything · Dec 4, 2024 · 923161f · 923161f
1 parent c9eaf82
commit 923161f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/framework/store/src/store/collection.ts b/packages/framework/store/src/store/collection.ts
@@ -234,6 +234,10 @@ export class DocCollection extends DocCollectionAddonType {
     return this.getDoc(docId, { query }) as Doc;
   }
 
+  dispose() {
+    this.awarenessStore.destroy();
+  }
+
   /**
    * Terminate the data sync process forcefully, which may cause data loss.
    * It is advised to invoke `canGracefulStop` before calling this method.

diff --git a/packages/framework/store/src/yjs/awareness.ts b/packages/framework/store/src/yjs/awareness.ts
@@ -94,10 +94,8 @@ export class AwarenessStore<Flags extends BlockSuiteFlags = BlockSuiteFlags> {
   }
 
   destroy() {
-    if (this.awareness) {
-      this.awareness.off('change', this._onAwarenessChange);
-      this.slots.update.dispose();
-    }
+    this.awareness.off('change', this._onAwarenessChange);
+    this.slots.update.dispose();
   }
 
   getFlag<Key extends keyof Flags>(field: Key) {