fix: no need to save aliases on embed synced doc model (#8884)

Closes: [BS-2067](https://linear.app/affine-design/issue/BS-2067/embed-view-加了-alias-之后变成-card-view，再切换成-embed-view，再切换会-card)

packages/affine/block-embed/src/embed-linked-doc-block/embed-edgeless-linked-doc-block.ts

@@ -1,3 +1,4 @@
+import { cloneReferenceInfoWithoutAliases } from '@blocksuite/affine-components/rich-text';
 import {
   EMBED_CARD_HEIGHT,
   EMBED_CARD_WIDTH,
@@ -35,7 +36,11 @@ export class EmbedEdgelessLinkedDocBlockComponent extends toEdgelessEmbedBlock(
     // @ts-expect-error TODO: fix after edgeless refactor
     const newId = edgelessService.addBlock(
       'affine:embed-synced-doc',
-      { xywh: bound.serialize(), caption, ...this.referenceInfo },
+      {
+        xywh: bound.serialize(),
+        caption,
+        ...cloneReferenceInfoWithoutAliases(this.referenceInfo),
+      },
       // @ts-expect-error TODO: fix after edgeless refactor
       edgelessService.surface
     );

packages/affine/block-embed/src/embed-linked-doc-block/embed-linked-doc-block.ts

@@ -9,6 +9,7 @@ import { BlockLinkIcon } from '@blocksuite/affine-components/icons';
 import { isPeekable, Peekable } from '@blocksuite/affine-components/peek';
 import {
   cloneReferenceInfo,
+  cloneReferenceInfoWithoutAliases,
   REFERENCE_NODE,
   referenceToNode,
   RefNodeSlotsProvider,
@@ -141,7 +142,7 @@ export class EmbedLinkedDocBlockComponent extends EmbedBlockComponent<EmbedLinke
 
     doc.addBlock(
       'affine:embed-synced-doc',
-      { caption, ...this.referenceInfo },
+      { caption, ...cloneReferenceInfoWithoutAliases(this.referenceInfo) },
       parent,
       index
     );

packages/affine/block-embed/src/embed-synced-doc-block/embed-synced-doc-block.ts

@@ -9,6 +9,7 @@ import {
   RefNodeSlotsProvider,
 } from '@blocksuite/affine-components/rich-text';
 import {
+  type AliasInfo,
   type DocMode,
   type EmbedSyncedDocModel,
   NoteDisplayMode,
@@ -254,7 +255,7 @@ export class EmbedSyncedDocBlockComponent extends EmbedBlockComponent<EmbedSynce
     width: '100%',
   });
 
-  convertToCard = () => {
+  convertToCard = (aliasInfo?: AliasInfo) => {
     const { doc, caption } = this.model;
 
     const parent = doc.getParent(this.model);
@@ -263,7 +264,7 @@ export class EmbedSyncedDocBlockComponent extends EmbedBlockComponent<EmbedSynce
 
     doc.addBlock(
       'affine:embed-linked-doc',
-      { caption, ...this.referenceInfo },
+      { caption, ...this.referenceInfo, ...aliasInfo },
       parent,
       index
     );

packages/affine/components/src/rich-text/inline/presets/nodes/index.ts

@@ -4,4 +4,8 @@ export * from './reference-node/reference-config.js';
 
 export { AffineReference } from './reference-node/reference-node.js';
 export type { RefNodeSlots } from './reference-node/types.js';
-export { cloneReferenceInfo, referenceToNode } from './reference-node/utils.js';
+export {
+  cloneReferenceInfo,
+  cloneReferenceInfoWithoutAliases,
+  referenceToNode,
+} from './reference-node/utils.js';

packages/affine/components/src/rich-text/inline/presets/nodes/reference-node/reference-popup.ts

@@ -36,6 +36,7 @@ import {
 import { RefNodeSlotsProvider } from '../../../../extension/index.js';
 import { ReferenceAliasPopup } from './reference-alias-popup.js';
 import { styles } from './styles.js';
+import { cloneReferenceInfoWithoutAliases } from './utils.js';
 
 export class ReferencePopup extends WithDisposable(LitElement) {
   static override styles = styles;
@@ -123,8 +124,14 @@ export class ReferencePopup extends WithDisposable(LitElement) {
 
     const index = parent.children.indexOf(block.model);
     const referenceInfo = this.referenceInfo;
+    const hasTitleAlias = Boolean(referenceInfo.title);
 
-    doc.addBlock('affine:embed-synced-doc', referenceInfo, parent, index + 1);
+    doc.addBlock(
+      'affine:embed-synced-doc',
+      cloneReferenceInfoWithoutAliases(referenceInfo),
+      parent,
+      index + 1
+    );
 
     const totalTextLength = this.inlineEditor.yTextLength;
     const inlineTextLength = this.targetInlineRange.length;
@@ -134,7 +141,9 @@ export class ReferencePopup extends WithDisposable(LitElement) {
       this.inlineEditor.insertText(this.targetInlineRange, this.docTitle);
     }
 
-    if (referenceInfo.title) notifyLinkedDocSwitchedToEmbed(std);
+    if (hasTitleAlias) {
+      notifyLinkedDocSwitchedToEmbed(std);
+    }
 
     this.abortController.abort();
   }

packages/affine/components/src/rich-text/inline/presets/nodes/reference-node/utils.ts

@@ -30,3 +30,16 @@ export function referenceToNode({ params }: ReferenceInfo) {
   if (databaseId || databaseRowId) return true;
   return false;
 }
+
+/**
+ * Clones reference info without the aliases.
+ * In `EmbedSyncedDocModel`, the aliases are not needed at the moment.
+ */
+export function cloneReferenceInfoWithoutAliases({
+  pageId,
+  params,
+}: ReferenceInfo) {
+  const info: ReferenceInfo = { pageId };
+  if (params) info.params = cloneDeep(params);
+  return info;
+}

packages/blocks/src/_common/components/embed-card/modal/embed-card-edit-modal.ts

@@ -1,6 +1,5 @@
 import type { AliasInfo } from '@blocksuite/affine-model';
 import type { BlockComponent, EditorHost } from '@blocksuite/block-std';
-import type { BlockProps } from '@blocksuite/store';
 
 import {
   EmbedLinkedDocBlockComponent,
@@ -178,11 +177,9 @@ export class EmbedCardEditModal extends SignalWatcher(
 
     const description = this.description$.value.trim();
 
-    const props: Partial<BlockProps> = { title };
+    const props: AliasInfo = { title };
     if (description) props.description = description;
 
-    this.model.doc.updateBlock(this.model, props);
-
     const blockComponent = this._blockComponent;
 
     if (
@@ -191,10 +188,11 @@ export class EmbedCardEditModal extends SignalWatcher(
     ) {
       const std = blockComponent.std;
 
-      blockComponent.convertToCard();
+      blockComponent.convertToCard(props);
 
       notifyLinkedDocSwitchedToCard(std);
     } else {
+      this.model.doc.updateBlock(this.model, props);
       blockComponent?.requestUpdate();
     }
 

packages/blocks/src/root-block/widgets/element-toolbar/change-embed-card-button.ts

@@ -394,7 +394,9 @@ export class EdgelessChangeEmbedCardButton extends WithDisposable(LitElement) {
 
     if (doc) {
       const title = doc.meta?.title;
-      const description = getDocContentWithMaxLength(doc);
+      const description = isEmbedLinkedDocBlock(model)
+        ? getDocContentWithMaxLength(doc)
+        : undefined;
       return { title, description };
     }
 

packages/blocks/src/root-block/widgets/embed-card-toolbar/embed-card-toolbar.ts

@@ -168,7 +168,9 @@ export class EmbedCardToolbar extends WidgetComponent<
 
     if (doc) {
       const title = doc.meta?.title;
-      const description = getDocContentWithMaxLength(doc);
+      const description = isEmbedLinkedDocBlock(model)
+        ? getDocContentWithMaxLength(doc)
+        : undefined;
       return { title, description };
     }
 
@@ -331,8 +333,9 @@ export class EmbedCardToolbar extends WidgetComponent<
 
       this.focusBlock.convertToEmbed();
 
-      if (referenceInfo.title || referenceInfo.description)
+      if (referenceInfo.title || referenceInfo.description) {
         notifyLinkedDocSwitchedToEmbed(this.std);
+      }
 
       return;
     }