Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(electron): split view tracking events #9896

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 26, 2025

fix AF-2037

Copy link
Collaborator Author

pengx17 commented Jan 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review January 26, 2025 09:58
@graphite-app graphite-app bot requested review from a team January 26, 2025 09:58
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.56%. Comparing base (d6bfb76) to head (a5c8356).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9896      +/-   ##
==========================================
+ Coverage   53.55%   53.56%   +0.01%     
==========================================
  Files        2281     2281              
  Lines      103679   103679              
  Branches    17199    17200       +1     
==========================================
+ Hits        55529    55540      +11     
+ Misses      46776    46766      -10     
+ Partials     1374     1373       -1     
Flag Coverage Δ
server-test 77.68% <ø> (+0.01%) ⬆️
unittest 31.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 27, 2025

Merge activity

@pengx17 pengx17 force-pushed the 01-26-chore_electron_split_view_tracking_events branch from d1bf650 to a5c8356 Compare January 27, 2025 02:40
@graphite-app graphite-app bot merged commit a5c8356 into canary Jan 27, 2025
63 checks passed
@graphite-app graphite-app bot deleted the 01-26-chore_electron_split_view_tracking_events branch January 27, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants