Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): minor bug fixes #9696

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Conversation

OlegDev1
Copy link
Contributor

Fixes #9644
Fixes #9645
Fixes #9647

Changes

Edit menu property style

As mentioned in #9644, the style of the edit menu property is not proper. It was changed, the height was set to 32px though, instead of 30px, since the sibling button has 32px of height.

Snapshot exported file name

As mentioned in #9645, when we export the snapshot its file name is the document id, instead of the document name. It was fixed. If the document doesn't have a title, the snapshot file will be named as untitled. The way the zip file, which stores all of the snapshots, is named is not changed.

Code block auto-completion

As mentioned in #9647, whenever we type a < into a code block the input is automatically converted to <>. This was fixed and the necessary test case has been added.

@OlegDev1 OlegDev1 requested a review from a team as a code owner January 14, 2025 22:00
@github-actions github-actions bot added test Related to test cases app:core labels Jan 14, 2025
Copy link

graphite-app bot commented Jan 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see codes changes for #9644. Did you forget to commit the related files?

@OlegDev1
Copy link
Contributor Author

I dont see codes changes for #9644. Did you forget to commit the related files?

I understand, it may be a little bit confusing. The fix for this issue is in the commit d045218. size="large" changes the height to 32px. Have a great day!

@OlegDev1 OlegDev1 requested a review from pengx17 January 15, 2025 07:29
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.53%. Comparing base (ffd54c6) to head (aab5997).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/blocks/src/_common/transformers/zip.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9696      +/-   ##
==========================================
- Coverage   53.55%   53.53%   -0.03%     
==========================================
  Files        2281     2281              
  Lines      103649   103649              
  Branches    17185    17184       -1     
==========================================
- Hits        55512    55484      -28     
- Misses      46755    46784      +29     
+ Partials     1382     1381       -1     
Flag Coverage Δ
server-test 77.61% <ø> (-0.07%) ⬇️
unittest 31.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saul-Mirone Saul-Mirone merged commit e3fac97 into toeverything:canary Jan 27, 2025
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
3 participants