-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): minor bug fixes #9696
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see codes changes for #9644. Did you forget to commit the related files?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9696 +/- ##
==========================================
- Coverage 53.55% 53.53% -0.03%
==========================================
Files 2281 2281
Lines 103649 103649
Branches 17185 17184 -1
==========================================
- Hits 55512 55484 -28
- Misses 46755 46784 +29
+ Partials 1382 1381 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #9644
Fixes #9645
Fixes #9647
Changes
Edit menu property style
As mentioned in #9644, the style of the edit menu property is not proper. It was changed, the height was set to 32px though, instead of 30px, since the sibling button has 32px of height.
Snapshot exported file name
As mentioned in #9645, when we export the snapshot its file name is the document id, instead of the document name. It was fixed. If the document doesn't have a title, the snapshot file will be named as untitled. The way the zip file, which stores all of the snapshots, is named is not changed.
Code block auto-completion
As mentioned in #9647, whenever we type a < into a code block the input is automatically converted to <>. This was fixed and the necessary test case has been added.