Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): make lit portal a bit cleaner #9354

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 26, 2024

No description provided.

Copy link
Collaborator Author

pengx17 commented Dec 26, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 51.45%. Comparing base (67be1fb) to head (153c1b2).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
.../component/src/lit-react/lit-portal/lit-portal.tsx 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9354      +/-   ##
==========================================
- Coverage   51.47%   51.45%   -0.02%     
==========================================
  Files        2156     2156              
  Lines       97651    97654       +3     
  Branches    16379    16377       -2     
==========================================
- Hits        50263    50247      -16     
+ Misses      46037    46017      -20     
- Partials     1351     1390      +39     
Flag Coverage Δ
server-test 78.31% <ø> (+0.06%) ⬆️
unittest 31.01% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 74f954a to bf5a115 Compare December 26, 2024 13:58
@fundon fundon requested a review from a team as a code owner December 26, 2024 13:58
@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch 2 times, most recently from d92acb2 to a74a077 Compare December 26, 2024 14:09
@fundon fundon force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 8d17ee7 to eb9165c Compare December 26, 2024 14:09
@pengx17 pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from a74a077 to 12b291c Compare December 26, 2024 15:15
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from eb9165c to fd8d4f5 Compare December 26, 2024 15:15
@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 12b291c to dc491aa Compare December 27, 2024 03:28
@fundon fundon force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from fd8d4f5 to d7b28dc Compare December 27, 2024 03:29
@pengx17 pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from dc491aa to beb61d2 Compare December 27, 2024 04:29
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch 2 times, most recently from bc82982 to 96f0c9d Compare December 27, 2024 05:02
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 96f0c9d to bcbb097 Compare December 27, 2024 05:17
@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from beb61d2 to e005a1a Compare December 27, 2024 05:57
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 89c391b to 291c555 Compare December 27, 2024 06:37
@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 8b6c427 to e18caac Compare December 27, 2024 07:09
@fundon fundon force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 291c555 to 1ff2875 Compare December 27, 2024 07:09
@pengx17 pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from e18caac to 8b6c427 Compare December 27, 2024 07:21
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 1ff2875 to 9f6b345 Compare December 27, 2024 07:21
@pengx17 pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 8b6c427 to 9936725 Compare December 27, 2024 07:22
@pengx17 pengx17 force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from 9f6b345 to fed048a Compare December 27, 2024 07:22
@fundon fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 9936725 to 6fcdd01 Compare December 27, 2024 07:43
@fundon fundon force-pushed the 12-26-refactor_core_make_lit_portal_a_bit_cleaner branch from fed048a to 368e462 Compare December 27, 2024 07:43
Base automatically changed from fundon/12_25_fix_lit_portal_re-rendering_issue to canary December 27, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants