Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): do not show toc in doc peek view #9348

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 26, 2024

fix AF-2025

Copy link
Collaborator Author

pengx17 commented Dec 26, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 force-pushed the xp/12-26-fix_mobile_do_not_show_toc_in_doc_peekview branch from 534bedf to 22c0f70 Compare December 26, 2024 11:05
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (893493c) to head (b3933e8).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9348      +/-   ##
==========================================
+ Coverage   51.44%   51.47%   +0.03%     
==========================================
  Files        2156     2156              
  Lines       97652    97652              
  Branches    16379    16379              
==========================================
+ Hits        50234    50270      +36     
+ Misses      46030    45989      -41     
- Partials     1388     1393       +5     
Flag Coverage Δ
server-test 78.24% <ø> (ø)
unittest 31.06% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 changed the title refactor(editor): extensionalize plain text adapter (#9330) fix(mobile): do not show toc in doc preview Dec 27, 2024
@pengx17 pengx17 changed the title fix(mobile): do not show toc in doc preview fix(mobile): do not show toc in doc peek view Dec 27, 2024
@pengx17 pengx17 marked this pull request as ready for review December 27, 2024 02:50
@pengx17 pengx17 force-pushed the xp/12-26-fix_mobile_do_not_show_toc_in_doc_peekview branch 2 times, most recently from e5cb17d to e1a318b Compare December 27, 2024 02:52
Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the xp/12-26-fix_mobile_do_not_show_toc_in_doc_peekview branch from e1a318b to b3933e8 Compare December 27, 2024 05:48
@graphite-app graphite-app bot merged commit b3933e8 into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the xp/12-26-fix_mobile_do_not_show_toc_in_doc_peekview branch December 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants