Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new worker workspace engine #9257

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 23, 2024

No description provided.

Copy link
Member Author

EYHN commented Dec 23, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 70 lines in your changes missing coverage. Please review.

Project coverage is 51.80%. Comparing base (129f94e) to head (0d82090).
Report is 12 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/frontend/doc.ts 4.25% 45 Missing ⚠️
...tend/core/src/modules/workspace/entities/engine.ts 0.00% 21 Missing ⚠️
packages/common/nbstore/src/sync/doc/index.ts 0.00% 3 Missing ⚠️
packages/common/nbstore/src/sync/doc/peer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9257      +/-   ##
==========================================
- Coverage   51.82%   51.80%   -0.02%     
==========================================
  Files        2119     2136      +17     
  Lines       97407    97430      +23     
  Branches    16666    16657       -9     
==========================================
- Hits        50477    50472       -5     
- Misses      45560    45592      +32     
+ Partials     1370     1366       -4     
Flag Coverage Δ
server-test 78.08% <ø> (-0.18%) ⬇️
unittest 30.92% <2.77%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant