Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): store real color values in edgeless #9254

Open
wants to merge 1 commit into
base: fundon/12_23_update_edgeless_color_palette
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 23, 2024

What's Changed!

  • adds theme type: ThemeSchema
  • adds default theme: DefaultTheme
  • stores real color values

Copy link
Contributor Author

fundon commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from fb93b95 to 04cf141 Compare December 23, 2024 14:13
@github-actions github-actions bot added the test Related to test cases label Dec 23, 2024
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 2 times, most recently from 0ca415e to 4dbadb3 Compare December 23, 2024 14:33
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 9e11e04 to aa795bd Compare December 23, 2024 14:37
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 3 times, most recently from 9fec4a5 to 44d739d Compare December 23, 2024 14:40
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from aa795bd to 67fb7ca Compare December 23, 2024 14:40
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 44d739d to cd3ec87 Compare December 23, 2024 14:40
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 48.07692% with 135 lines in your changes missing coverage. Please review.

Project coverage is 51.37%. Comparing base (bbd7b50) to head (4d32244).

Files with missing lines Patch % Lines
...ock/widgets/element-toolbar/change-shape-button.ts 49.01% 22 Missing and 4 partials ⚠️
...widgets/element-toolbar/change-connector-button.ts 11.53% 23 Missing ⚠️
...ock/widgets/element-toolbar/change-brush-button.ts 0.00% 15 Missing ⚠️
...ock/widgets/element-toolbar/change-frame-button.ts 12.50% 14 Missing ⚠️
...-block/widgets/element-toolbar/change-text-menu.ts 0.00% 9 Missing ⚠️
...k/edgeless/components/color-picker/color-picker.ts 0.00% 8 Missing ⚠️
...ot-block/edgeless/components/color-picker/utils.ts 12.50% 7 Missing ⚠️
...ck/edgeless/components/toolbar/shape/shape-menu.ts 0.00% 7 Missing ⚠️
...lock/widgets/element-toolbar/change-note-button.ts 53.84% 5 Missing and 1 partial ⚠️
...t-block/edgeless/components/color-picker/button.ts 50.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@                              Coverage Diff                               @@
##           fundon/12_23_update_edgeless_color_palette    #9254      +/-   ##
==============================================================================
+ Coverage                                       49.91%   51.37%   +1.46%     
==============================================================================
  Files                                            2128     2159      +31     
  Lines                                           96871    97536     +665     
  Branches                                        16228    16317      +89     
==============================================================================
+ Hits                                            48355    50113    +1758     
+ Misses                                          47022    46036     -986     
+ Partials                                         1494     1387     -107     
Flag Coverage Δ
server-test 78.19% <ø> (-0.06%) ⬇️
unittest 30.97% <40.38%> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 5 times, most recently from d690394 to 74b4433 Compare December 24, 2024 04:41
@fundon fundon changed the title feat: store real color values in edgeless feat(editor): store real color values in edgeless Dec 24, 2024
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 67fb7ca to 4eb17c1 Compare December 24, 2024 05:17
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 5 times, most recently from add24e1 to 93d7525 Compare December 24, 2024 06:14
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 4eb17c1 to 49033af Compare December 24, 2024 06:24
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 3 times, most recently from 9c7fac8 to 9907200 Compare December 24, 2024 06:44
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 9c3131a to ef4ab92 Compare December 27, 2024 05:48
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 807b748 to 89db587 Compare December 27, 2024 07:54
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from ef4ab92 to 57f68e7 Compare December 27, 2024 07:54
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 89db587 to 76b6292 Compare December 27, 2024 08:00
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 57f68e7 to cf7c8d8 Compare December 27, 2024 08:00
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 76b6292 to 38b9ae6 Compare December 27, 2024 08:41
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from cf7c8d8 to 3929ac5 Compare December 27, 2024 08:41
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 38b9ae6 to 82f96d4 Compare December 27, 2024 08:54
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 2 times, most recently from 69c2bb7 to f2c9d11 Compare December 27, 2024 08:57
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 82f96d4 to 16313f5 Compare December 27, 2024 09:31
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from f2c9d11 to f5674db Compare December 27, 2024 09:31
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 16313f5 to 37d772c Compare December 27, 2024 09:38
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 2 times, most recently from 36f36db to ca19347 Compare December 27, 2024 09:42
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 37d772c to f7793db Compare December 27, 2024 09:54
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 2 times, most recently from c54e6a6 to cb3bf0d Compare December 27, 2024 10:06
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from f7793db to bbd7b50 Compare December 27, 2024 10:24
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from cb3bf0d to 4d32244 Compare December 27, 2024 10:24
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from bbd7b50 to ca0580a Compare December 27, 2024 13:20
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 4d32244 to 5917d08 Compare December 27, 2024 13:20
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 5917d08 to e2d430b Compare December 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants